Repository navigation
Route TDL (tree_learner) output through logging instead of print - #657
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the
printto logger cleanup PRs (Improvements.md§3). Stacked on #656: the base isrefactor/nces-loggingso theImprovements.md/CHANGELOG edits don't conflict; GitHub retargets this todevelopwhen #656 merges.learners/tree_learner.py: the 12 liveprintcalls becomelogger.info(keeping their existingverbosegates).if self.verbose > 0: print("Warning: Error extracting ... features")lines, which only duplicated thelogger.warning(..., exc_info=True)right above them.print(matches in the file are in comments / dead string blocks (AST check: no realprintcalls left).Improvements.mdcounts and CHANGELOG updated.Local: tdl, tdl_refinement and both regression test files: 86 passed; ruff clean.
🤖 Generated with Claude Code