Skip to content

fix: reject unready golden sandboxes#548

Open
ZIJ wants to merge 2 commits into
mainfrom
fix/golden-sandbox-readiness
Open

fix: reject unready golden sandboxes#548
ZIJ wants to merge 2 commits into
mainfrom
fix/golden-sandbox-readiness

Conversation

@ZIJ

@ZIJ ZIJ commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

TL;DR

A golden-restored VM accepted its agent socket but could not serve any RPC. The worker still marked it running; network setup consumed 80s, best-effort log setup held the request until Cloudflare returned 524, and the unusable VM was orphaned.

Consequential decisions

  • Require a real agent Ping after socket connect; retry once after redial for the known post-loadvm stale connection.
  • Treat failed network patching as a failed golden restore, using the existing clean cold-boot fallback instead of publishing a broken sandbox.
  • Bound best-effort log configuration to 5s so it cannot consume the public create deadline.
  • No API, schema, placement, or healthy fast-path behavior changes; the failure mode becomes a slower cold boot.

Verification

  • go test ./internal/qemu -run '^$' (compile)
  • go test ./internal/worker
  • The broader local qemu suite reaches an existing host dependency failure because qemu-img is not installed; changed packages compile.

Production evidence

The incident VM restored in 274ms, then both network RPC attempts and clock sync timed out. Log configuration remained blocked until request cancellation, matching the 524 seen by sessions-api.

@2027-evals

2027-evals Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ Couldn't find a preview deployment for commit b907194 after 10 minutes.

2027 auto-runs evals against preview deployments of your docs. To enable this, install one of:

  • Mintlify — if you use Mintlify docs
  • Vercel — for Next.js / static sites
  • Netlify — for most static docs

Once a preview is deployed, open a new PR and we'll run the eval automatically.


Evaluating agent experience using 2027.dev · View dashboard

@ZIJ
ZIJ requested review from breardon2011 and motatoes July 24, 2026 16:30

@breardon2011 breardon2011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@breardon2011 breardon2011 mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants