This repository was archived by the owner on Jul 12, 2026. It is now read-only.
Repository navigation
Expose impulse joint motor max force - #371
Merged
Merged
Conversation
zdtango
marked this pull request as ready for review
May 23, 2026 01:06
zdtango
marked this pull request as draft
May 23, 2026 01:07
zdtango
marked this pull request as ready for review
May 23, 2026 01:16
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
setMotorMaxForce(maxForce)onUnitImpulseJointfor JavaScript users.Rapier core already exposes this through
set_motor_max_force, but the JS/WASM wrapper currently exposes motor model/velocity/position configuration without exposing the separate max-force setter.Why
This lets JS users cap solver-level joint motor force/torque directly instead of approximating motor force limits outside the joint solver. It is useful for cases like vehicle wheel motors, brakes, doors, and robotics where motor targets need a finite force limit.
Changes
RawImpulseJointSet.jointSetMotorMaxForce(...)in the wasm binding layer.UnitImpulseJoint.setMotorMaxForce(maxForce)in the TypeScript wrapper.Validation
cargo check -p dimforge_rapier3dcargo fmt --check -- src/dynamics/impulse_joint.rsnpx prettier --check src.ts/dynamics/impulse_joint.ts