Skip to content

Fix tree depth query. - #718

Merged
chyunsu3 merged 3 commits into
dmlc:mainlinefrom
trivialfis:fix-get-depth
Oct 27, 2026
Merged

chyunsu3 merged 3 commits into
dmlc:mainlinefrom
trivialfis:fix-get-depth

Conversation

@trivialfis

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.15%. Comparing base (98b3e45) to head (8655762).

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #718      +/-   ##
============================================
- Coverage     84.16%   84.15%   -0.01%     
============================================
  Files            75       75              
  Lines          6928     6925       -3     
  Branches        560      560              
============================================
- Hits           5831     5828       -3     
  Misses         1097     1097              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trivialfis

Copy link
Copy Markdown
Member Author

cc @chyunsu3

@chyunsu3 chyunsu3 mentioned this pull request Oct 27, 2026
1 task done
@chyunsu3
chyunsu3 merged commit e6005ae into dmlc:mainline Oct 27, 2026
20 checks passed
chyunsu3 added a commit that referenced this pull request Oct 27, 2026
* Bump version to 4.8.1

* Fix tree depth query. (#718)

* Fix tree depth query.

* black.

* Add test with model builder

---------

Co-authored-by: Hyunsu Cho <phcho@nvidia.com>

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
@trivialfis
trivialfis deleted the fix-get-depth branch October 28, 2026 07:32
rapids-bot Bot pushed a commit to NVIDIA/cuml that referenced this pull request Oct 29, 2026
Update Treelite to 4.8.1 to bring in bug fixes and improvements:

* Export more metadata from `export_model()` in dmlc/treelite#684
* Fix import for DART in XGBoost 3.3 and 3.4 in dmlc/treelite#688
* Exporter: export `classes_` attribute for subestimator of RF in dmlc/treelite#686
* Add missing value support in scikit-learn random forest models by in dmlc/treelite#695
* Support `reg:absoluteerror` and `reg:quantileerror` XGBoost objectives in dmlc/treelite#712
* Raise an error for LightGBM models with linear trees in dmlc/treelite#711
* Apply the log link for `HistGradientBoostingRegressor` with poisson or gamma loss in dmlc/treelite#710
* Fix tree depth query (dmlc/treelite#718). This functionality affects `treelite.sklearn.export_model` (used by `cuml.accel`).

Authors:
  - Philip Hyunsu Cho (https://github.com/chyunsu3)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #8827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants