Skip to content

Cleanup GPU histogram tests. - #12647

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:refactor-hist-tests
Oct 4, 2026
Merged

trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:refactor-hist-tests

Conversation

@trivialfis

Copy link
Copy Markdown
Member

Extracted from #12630

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c1fb8e81-8d3a-479f-83a9-f54d3b3286ab

📥 Commits

Reviewing files that changed from the base of the PR and between 889c4d2 and 036c453.

📒 Files selected for processing (5)
  • tests/cpp/histogram_helpers.cu
  • tests/cpp/histogram_helpers.h
  • tests/cpp/test_histogram_helpers.cu
  • tests/cpp/tree/gpu_hist/test_histogram.cu
  • tests/cpp/tree/gpu_hist/test_multi_histogram.cu
💤 Files with no reviewable changes (3)
  • tests/cpp/test_histogram_helpers.cu
  • tests/cpp/histogram_helpers.cu
  • tests/cpp/tree/gpu_hist/test_multi_histogram.cu

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

The change updates ELLPACK test support and removes the MakeEllpackForTest helper and its test. GPU histogram tests add deterministic input generation and compare built device histograms with independently accumulated expected values. The tests also add parameterized layout and memory cases, large-row and wide-feature coverage, and shared-memory budget checks. Existing subtraction and categorical-gradient tests change, and the separate multi-histogram test suites are removed.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 036c4

No actionable issue is established in the CUDA histogram test changes. The PR is ready to merge after normal checks.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@trivialfis
trivialfis requested a review from RAMitchell October 2, 2026 10:26
@trivialfis
trivialfis merged commit baa25e6 into dmlc:master Oct 4, 2026
84 checks passed
@trivialfis
trivialfis deleted the refactor-hist-tests branch October 4, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants