Fix Attribute name usage - #1811
Open
RexJaeschke wants to merge 2 commits into
Open
RexJaeschke wants to merge 2 commits into
RexJaeschke wants to merge 2 commits into
Conversation
Contributor
By "omit it" do you mean the namespace? If so, I agree. If it's the |
Contributor
Author
|
@jskeet Yes, I meant "omit the namespace." I did that for the Attribute types in attributes.md. However, I did not do that for such types mentioned in classes.md, a clause that uses the namespace prefix |
jskeet
approved these changes
Sep 14, 2026
jskeet
left a comment
jskeet
left a comment
Contributor
There was a problem hiding this comment.
Yup, this looks fine to me, given that we've got the full namespace elsewhere (and it's a real mouthful).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jon, here's one more occurrence. Separately, I'll go through all the Draft PR's for V8 and later versions and apply your rules to all new relevant attribute-related text.
@jon, hold off approving this just yet as I may have more tweaks.
For example, 23.5.6.2 The CallerLineNumber attribute (among other specific attribute subclauses) uses a fully qualified name for the attribute type, as in
As we state the fully qualified name back in 23.5.1 General, I suggest we omit it from all other uses in narrative. Do you agree? If so, I'll fix those as part of this PR.