Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
am11
force-pushed
the
illink-impl-references
branch
from
October 27, 2026 00:44
63ecb76 to
78656c1
Compare
Member
Author
Member
|
@sbomer Could you please take a look? |
# Conflicts: # src/coreclr/vm/wasm/wasi/callhelpers-pinvoke.cpp
sbomer
reviewed
Oct 29, 2026
sbomer
left a comment
Member
There was a problem hiding this comment.
Do we need to somehow prevent baking in constants from an OOB library that might change across versions?
- Use the reference assembly of packable libraries, which can be replaced by a newer package at run time. - Trim after CoreCompile with the implementation references as inputs, so changes to them are picked up incrementally. - Don't disable the optimization when BuildAllConfigurations is set, which -pack sets for shipping builds. - Allow --ignore-substitutions in the cacheable ILLink task arguments. - Make not updating reference scopes the default in library mode instead of a new option.
Member
Author
Packable libraries now contribute their reference assembly instead of the implementation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic version of @#136476.
main