Conversation
Signed-off-by: Gopesh111 <gopesh.22bce7700@vitapstudent.ac.in>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1997 where
MLXLMTypeAdapter.format_output_typeandMLXLM.generate_batchused truthiness checks (if output_type:/if not output_type:) instead of explicit identity checks (if output_type is None:/if output_type is not None:).Using boolean truthiness checks causes falsy custom logits processors or objects (such as structures defining
__len__ = 0) to be wrongly evaluated asNoneor skip unsupported batch argument assertions.Test Plan
Added unit test
test_mlxlm_type_adapter_format_output_type_none_and_falsyintests/models/test_mlxlm_type_adapter.pyverifying thatformat_output_type(None)returnsNoneandformat_output_type(falsy_obj)returns[falsy_obj].Run pytest locally: