Conversation
…on and UI updates
12 tasks
b0ink
requested changes
Jun 25, 2026
b0ink
left a comment
b0ink
left a comment
Member
There was a problem hiding this comment.
This feature will need to be rebased on to the 11.0.x branch before progressing
b0ink
requested changes
Jun 25, 2026
b0ink
left a comment
b0ink
left a comment
Member
There was a problem hiding this comment.
Seems like the feature is incomplete and requires a bit of work to polish up
Comment on lines
+32
to
+46
| students = [ | ||
| { id: 1, name: 'Joe M' }, | ||
| { id: 2, name: 'Sahiru W' }, | ||
| { id: 3, name: 'Samindi M' }, | ||
| { id: 4, name: 'Samantha W' }, | ||
| { id: 5, name: 'Samantha M' }, | ||
| { id: 6, name: 'Samantha S' }, | ||
| { id: 7, name: 'Samantha T' }, | ||
| { id: 8, name: 'Samantha U' }, | ||
| { id: 9, name: 'Samantha V' }, | ||
| { id: 10, name: 'Samantha W' }, | ||
| { id: 11, name: 'Samantha X' }, | ||
| { id: 12, name: 'Samantha Y' }, | ||
| { id: 13, name: 'Samantha Z' } | ||
| ]; |
Member
There was a problem hiding this comment.
Students list also needs to be fetched properly instead of these placeholders
| }, | ||
| ): Observable<any> { | ||
| return this.httpClient.post(this.AUTH_URL, userCredentials).pipe( | ||
| return this.httpClient.post(this.AUTH_URL, userCredentials, { withCredentials: true }).pipe( |
Member
There was a problem hiding this comment.
withCredentials should not be required here
Comment on lines
+27
to
+30
| const headers = new HttpHeaders({ | ||
| 'Auth-Token': authToken, | ||
| 'Username': username | ||
| }); |
Member
There was a problem hiding this comment.
auth token should not have to be passed manually
Member
|
Superseded by #1074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Staff Grant Extension modal introduced in #948 by adding support for multi-student selection, allowing staff to grant extensions to multiple students simultaneously. This feature is accessible for admins under the units page.
Note: This branch only contains frontend related changes.
Full documentation for this feature can be found here: https://thoth-tech.netlify.app/products/ontrack/projects/staff-grant-extension/design/
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Screenshot
Testing Checklist:
Checklist: