fix(QuickFiler): use 24-hour time format for session-metrics timestamps (#645)

[drmoisan]

Suggested title

fix(quickfiler): render session-metrics time-of-day as 24-hour HH:mm (issue #645)

Summary

• Fixes three ambiguous 12-hour .NET time-of-day format strings ("hh:mm", no AM/PM designator) in the QuickFiler and EFC session-metrics CSV writers, changing them to unambiguous 24-hour "HH:mm".
• Every session-metrics row written since the format was introduced carried an indistinguishable time (14:30 rendered identically to 02:30); this change alters the emitted CSV's time-of-day column content going forward.
• Updates the three dependent test-literal/doc-comment sites so the existing regression tests continue to assert the corrected rendering.
• No CSV field order, field count, or unrelated field content changes; no CultureInfo.InvariantCulture argument was added to the fixed call sites (that gap is tracked separately as issue Bug: quickfiler-date-time-format-missing-invariant-culture #742, intentionally out of scope here).
• A repository-hygiene defect discovered during review (an absolute local file path and Windows account name leaking into two committed Cobertura coverage-evidence XML files) was found and remediated in a separate, self-contained commit before this PR was opened.

Why

The QuickFiler and EFC session-metrics writers used the .NET custom format string "hh:mm" for the time-of-day column. hh is the 12-hour-clock specifier, and the format carries no tt (AM/PM) designator, so an afternoon timestamp such as 14:30 renders as 02:30, which is byte-identical to an early-morning 02:30. The emitted CSV is a real, human-consumed artifact (read by a maintained spreadsheet outside this repository), so the defect is a silent correctness problem in production output, not merely a display nuisance. The fix is a minimal format-string substitution with no other logic, control-flow, or field-order change.

What Changed

Core fix (production code):

• QuickFiler/Controllers/QfcHomeController.Metrics.cs — line 48 (dataLineBeg interpolation) and line 127 (curTimeText assignment): "hh:mm" → "HH:mm".
• QuickFiler/Controllers/EfcHomeController.Metrics.cs — line 96 (curTimeText assignment): "hh:mm" → "HH:mm".

Tests:

• QuickFiler.Test/Controllers/QfcHomeControllerMetricsTests.cs — updated the asserted literal in two test methods (WriteMetricsAsync_UsesInjectedClock_ForDateAndTimeStamps, QuickFileMetrics_WRITE_UsesInjectedClock_ForDataLine) and their doc-comments from "hh:mm" to "HH:mm".
• QuickFiler.Test/Controllers/EfcHomeControllerMetricsTests.cs — updated the asserted time-of-day literal in BuildQuickFileMetricLines_WithMovedMailItems_FormatsMetricLine from 01:05 to 13:05 (matching the fixture's MetricsNow = 2026-07-04 13:05:00 under the corrected 24-hour rendering).

Evidence-hygiene remediation (separate commit, no production/test code):

• Redacted an absolute local worktree path and Windows account name (2,007 occurrences per file) that leaked into two committed Cobertura coverage-evidence XML files during the delivery process. Substitution only; both files re-verified as well-formed XML after the change.

Docs:

• docs/features/active/quickfiler-session-metrics-twelve-hour-time-format-645/ — issue, spec, research, atomic plan, remediation plan, and full evidence trail (baseline captures, QA-gate results, regression-testing verification, two full policy/code/feature review cycles).

Architecture / How It Fits Together

No architectural change. Both writers construct a CSV data line by string-interpolating a DateTimeOffset/DateTime value obtained from an injected clock (TimeProvider or an injected clock factory, not the wall clock) through .ToString("HH:mm") instead of .ToString("hh:mm"). The change is confined to the format-string literal at each of the three call sites; the surrounding control flow, CSV field composition, and clock-injection seam are unchanged.

Verification

Completed (from evidence artifacts in this branch):

• CSharpier format/check on the four in-scope files: EXIT_CODE: 0 (no reformat needed).
• Analyzer rebuild (msbuild /t:Rebuild /p:EnableNETAnalyzers=true /p:EnforceCodeStyleInBuild=true): EXIT_CODE: 0.
• Nullable rebuild (msbuild /t:Rebuild /p:TreatWarningsAsErrors=true): EXIT_CODE: 0.
• Scoped regression run (the two QfcHomeControllerMetricsTests methods and the EfcHomeControllerMetricsTests fixed-clock test): 0 failed, both before and after the source edit.
• Full QuickFiler.Test assembly run (coverage-enabled): 1312/1312 passed.
• Scope-boundary diff check: only the four in-scope source/test files and this feature's docs/ tree are touched; no file under QuickFiler/Legacy/, TaskVisualization/TaskViewer.Designer.cs, .claude/**, config/blast-radius.json, or config/orchestration-routing.json appears in the branch diff.
• Two full policy/code/feature-audit review cycles (pre-remediation and post-remediation reaudit) both independently re-derived these results; the reaudit additionally confirmed the evidence-hygiene fix removed all 2,007 leaked-path occurrences per file with zero regression to the production fix.
• Repository-wide C# coverage (23.8225%) is below the repository's stated floor, but is unchanged from this branch's own baseline (Delta = 0.0000 percentage points) — a pre-existing, repository-wide condition unrelated to this change; the three changed lines and their four dependent test-literal updates are covered by the existing, passing tests named above.

Recommended:

• CI's standard build/test pipeline for this branch (not run interactively as part of this delivery).

Backward Compatibility / Migration Notes

This change alters the emitted session-metrics CSV: the time-of-day column now renders on a 24-hour clock (HH:mm) instead of the previous ambiguous 12-hour rendering (hh:mm, no AM/PM designator). Any downstream consumer of this CSV (the maintained spreadsheet referenced in the linked issue) should be aware that afternoon/evening timestamps will now render as digits >= 13 (e.g., 14:30 instead of the previously ambiguous 02:30). No column is added, removed, or reordered.

Risks and Mitigations

• Risk: A downstream consumer parses the time-of-day column expecting 12-hour values. Mitigation: the column was always intended to be unambiguous; this fix corrects a pre-existing correctness defect rather than introducing new behavior, and the change is called out explicitly here and in the linked issue.
• Risk: The evidence-hygiene remediation's substitution could have corrupted the Cobertura XML. Mitigation: both files were verified well-formed XML after redaction, and their filename="..." attribute count was confirmed unchanged before/after (value-only substitution, not a structural rewrite).

Review Guide

Suggested order:

1. QuickFiler/Controllers/QfcHomeController.Metrics.cs and QuickFiler/Controllers/EfcHomeController.Metrics.cs — the three one-line format-string changes.
2. QuickFiler.Test/Controllers/QfcHomeControllerMetricsTests.cs and QuickFiler.Test/Controllers/EfcHomeControllerMetricsTests.cs — the matching test-literal updates.
3. docs/features/active/quickfiler-session-metrics-twelve-hour-time-format-645/spec.md — acceptance criteria (all 10 checked off) and scope boundary.
4. The evidence tree, if a detailed audit trail is wanted; it is large (Cobertura XML files are the bulk of the diff by line count) but mechanical.

Follow-ups

• Issue Bug: quickfiler-date-time-format-missing-invariant-culture #742 (already promoted, separate from this PR): none of the three fixed call sites pass CultureInfo.InvariantCulture; that gap is tracked and intentionally out of scope here.

GitHub Auto-close

• None (GitHub CLI was unavailable when this PR context was collected, so the closing reference could not be verified against live issue metadata in this environment; this branch and its docs/features/active/quickfiler-session-metrics-twelve-hour-time-format-645/ folder target issue Bug: quickfiler-session-metrics-twelve-hour-time-format #645 — add Closes #645 when opening the PR if the issue-linking convention is confirmed at that time.)