[Test] keeper-tx.ts has no test file

[collinsezedike]

Description

There is no keeper-tx.test.ts anywhere in packages/stellar-sdk-helpers, even though keeper-tx.ts exports several pure, easily-testable classification functions: isDefinitiveOnChainFailure (lines 71-73), isTransientKeeperError (lines 95-107, including the status-code regex at line 89), isStaleAdapterError (lines 152-154), and expectString (lines 115-126).

Acceptance Criteria

• New keeper-tx.test.ts covers isTransientKeeperError: returns true for a SubmissionInFlightError and for messages matching 429/503/"rate limit", false for a SubmissionFailedError.
• Covers expectString: throws for a non-string value (e.g. null or a number), returns the value unchanged for a string.
• pnpm test (stellar-sdk-helpers package) passes.

[AzahasTech]

@AzahasTech has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I’d love to take ownership of this issue and submit a high-quality pull request once completed.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @AzahasTech to this issue.

[Mhidesav]

@Mhidesav has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hi
i would like to work on this issue please

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mhidesav to this issue.

[nancybexter90-ctrl]

@nancybexter90-ctrl has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’ve reviewed the issue and understand what’s required. I’m ready to take it on and deliver a clean, reliable solution.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nancybexter90-ctrl to this issue.

[Otfrugger]

@Otfrugger has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on Issue #657 because keeper-tx.ts contains several pure classification and validation helpers that are currently completely untested. These functions influence how keeper transactions distinguish transient failures from definitive failures, so regressions could silently change retry behavior.

I will first review packages/stellar-sdk-helpers/keeper-tx.ts and the package's existing test conventions to understand the exported helper signatures and the available error classes.

I will then add a new keeper-tx.test.ts covering the required behavior of isTransientKeeperError and expectString.

For isTransientKeeperError, I will verify that it returns true for a SubmissionInFlightError and for error messages representing transient conditions such as HTTP 429, 503, and rate-limit failures. I will also verify that a SubmissionFailedError is classified as non-transient.

For expectString, I will test that non-string values such as null and numbers throw the expected error, while a valid string is returned unchanged.

I will keep the tests focused on observable behavior and avoid involving live Stellar RPC calls or keeper infrastructure since these helpers are deterministic and can be tested entirely in isolation.

I will also review the existing isDefinitiveOnChainFailure and isStaleAdapterError helpers so the new test file is structured to allow straightforward coverage expansion without introducing unnecessary dependencies.

Finally, I will run the stellar-sdk-helpers package test suite with pnpm test and verify that the new tests pass alongside all existing tests.

My goal is to establish direct regression coverage for keeper error classification and input validation so changes to retry behavior or runtime error handling are detected immediately.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Otfrugger to this issue.

[DevQwinB]

@DevQwinB has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

times almost up but i got this test file covered if assigned

ℹ️ Repo Maintainers: To accept this application, review their application or assign @DevQwinB to this issue.

[drips-wave]

Congratulations, @DevQwinB! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @DevQwinB: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊