test(defindex-adapter): cover deposit()'s NotInitialized panic when DFX_VAULT is unset

[ibochivincent-lang]

closes #664

Summary

deposit() in packages/contracts/defindex-adapter/src/lib.rs calls get_or_not_initialized for DFX_VAULT, the identical panic path withdraw() already had a test for (withdraw_panics_with_typed_error_when_dfx_vault_is_unset). No test exercised the same branch on the deposit() side.

Changes

Added deposit_panics_with_typed_error_when_dfx_vault_is_unset, mirroring the existing withdraw test's structure: constructs the adapter via setup(), removes DFX_VAULT from instance storage with env.as_contract, and asserts adapter.deposit(&amount) panics with the typed NotInitialized error. No USDC funding step is needed (unlike the withdraw test) since the NotInitialized check runs before any token movement.

Test plan

cargo test --lib -p meridian-defindex-adapter: 15 tests pass (14 existing + 1 new).

Note: this repo's packages/contracts workspace hits a pre-existing, Windows-toolchain-specific linker limit (ld: error: export ordinal too large) when defindex-adapter's [dev-dependencies] build meridian-vault for its own test binary, unrelated to this change — confirmed present on a clean main checkout with none of my edits. I verified the test passes by temporarily setting vault's [lib] crate-type to ["rlib"] (dropping the cdylib output that trips the Windows-only linker limit) for the local test run only, then reverted that change before committing — it is not part of this PR's diff.

stellar contract build --package meridian-defindex-adapter also succeeds cleanly, confirming the real WASM deployment target is unaffected either way.

Caveats

Per the issue's own note, this file also has #634 and #622 open against it touching unrelated parts of the same source — any merge conflict on this PR is from those landing first, not a real dependency.

[drips-wave]

@ibochivincent-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[vercel]

@ibochivincent-lang is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

[collinsezedike]

Verified: deposit() reads DFX_VAULT via get_or_not_initialized right after require_vault_auth and before any token movement, so removing it directly and expecting a typed NotInitialized panic is correct. Commit message was over the 72-char limit, reworded and pushed. Merging now.