fix(build): resolve production deploy failures in Vercel's function build - #700
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
collinsezedike
force-pushed
the
fix/vercel-production-build
branch
from
September 1, 2026 09:52
074aae0 to
7367ff7
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production has failed to deploy on every merge to main since #635, roughly 14 hours as of this PR. The root cause is two independent build bugs that a "redeploy without build cache" does not fix, since neither is actually a caching issue:
api/**/*.tscannot reliably resolve@meridian/shared/@meridian/api-core/@meridian/stellar-sdk-helpers's exports through theirpackage.json#typesfield, which points directly atsrc/index.ts.scripts/build-vercel.shonly esbuild-bundles these three packages' JS and never generates their.d.tsfiles, even though each package's owntsconfig.jsonalready setsdeclaration: true. Fixed by runningtsc --emitDeclarationOnlyfor each in the build script and pointingtypesat the resultingdist/index.d.ts.apps/webbuild fails outright withRolldown failed to resolve import "tslib"fromrxjs, a transitive dependency of@creit.tech/xbull-wallet-connect(added in feat(wallet): add XBullWallet adapter #598).rxjs's ESM5 build importstslibwithout it being resolvable in the dependency tree under Vite 8's Rolldown bundler. Fixed by addingtslibas a direct dependency ofapps/web.Both were verified by running
scripts/build-vercel.shlocally end to end, which now completes successfully and produces the fulldist/output (landing, app, docs) that previously failed on both counts.Test plan
bash scripts/build-vercel.sh(viapnpm exec) completes successfully end to endpnpm typecheckandpnpm typecheck:apipasspnpm lintpassespnpm testpasses (146/146 web tests, full suite).d.tsfiles forshared/api-core/stellar-sdk-helperscontain the expected exports