fix(api): add nil guard in volume mount response conversion - #3451
Open
chill-czar wants to merge 1 commit into
Open
fix(api): add nil guard in volume mount response conversion#3451chill-czar wants to merge 1 commit into
chill-czar wants to merge 1 commit into
Conversation
chill-czar
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
July 29, 2026 18:51
Contributor
Author
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3450
Summary
if item == nil { continue }guard inconvertFromDBMountsToAPIMountswithinpackages/api/internal/handlers/sandboxes_list.go.TestConvertFromDBMountsToAPIMountsunit tests inpackages/api/internal/handlers/volume_util_test.goasserting nil items are skipped safely without panicking.Why
When converting database volume mount configs to API response models,
convertFromDBMountsToAPIMountsiterated over the slice items directly. If anilpointer existed in the slice (e.g. from JSONB unmarshaling edge cases), dereferencingitem.Nameoritem.Pathtriggered a nil pointer panic, crashing the active request handler goroutine forGET /sandboxes/{id}orGET /v2/sandboxes. Adding an explicit nil check guarantees handler safety.Test Plan
go test -race -v -run TestConvertFromDBMountsToAPIMounts ./packages/api/internal/handlers/...go fmt ./.../cc @jakubno @dobrac @ValentaTomas @arkamar @tvi