Skip to content

Use sinc in ChudleyElliottJumpDiffusion width dependency expression once supported for Parameters #272

Open

Description

@markbujehein

ChudleyElliottJumpDiffusion._write_width_dependency_expression currently writes
the Chudley-Elliott width as

(hbar / tau) * (1 - sin(Q * l.value) / (Q * l.value))

because sinc isn't available for Parameters yet. This also affects a few cases in the unit tests. Support for it is being
implemented in easyscience/core:

Once that PR is merged and released, and dynamics-lib depends on a version that
includes it, replace the explicit sin(x)/x with sinc.

To do:

Raised in review of #246.

Activity

  1. added
    [scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)
    and removed
    [scope] ⚠️ label neededAutomatically added to issues and PRs without a [scope] label
    on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [priority] mediumNormal/default priority[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions