Repository navigation
wasapi: preserve GetBuffer Win32 HRESULT errors - #312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
GetBuffer formats E_OUTOFMEMORY as plain text, so the existing bounded OOM recovery in wasapiContext.run cannot recognize it with errors.Is. Wrap Win32 HRESULTs in the existing _WIN32_ERR type, preserving the AUDCLNT path and other HRESULT diagnostics.
Validation: a private harness extracted the actual wrapper and substituted its native syscall result. OOM failed errors.Is before the fix and passed afterward; DEVICE_INVALIDATED and RESOURCES_INVALIDATED remained recognizable. This is a wrapper regression check, not native Windows device testing.
Native macOS builds and internal package race tests passed, as did Windows 386/amd64/arm64 and WebAssembly cross-builds. The full macOS suite fails AudioQueueStart and then times out in TestSetBufferSize on both the unchanged upstream and this checkout; macOS vet reports the same pre-existing driver_darwin.go unsafe.Pointer warning.