Use pyTooling's ConfigurationException instead of a second one - #105
Open
eda-s-claude-bot[bot] wants to merge 2 commits into
Open
Use pyTooling's ConfigurationException instead of a second one#105eda-s-claude-bot[bot] wants to merge 2 commits into
eda-s-claude-bot[bot] wants to merge 2 commits into
Conversation
'pyEDAA.OutputFilter.CLI.Configuration' declared its own 'ConfigurationException', while pyTooling has carried one since 'pyTooling.Configuration' existed. Two unrelated classes shared a name across packages that are used together, and 'except ConfigurationException' meant different things depending on which had been imported. The local class is gone; both modules import pyTooling's. Its base is 'ToolingException', which brings the notes API the handler in 'main()' already reads through 'HasNotes'/'Notes'. One consequence worth naming: a configuration error is no longer an 'OutputFilterException'. 'main()' catches 'ConfigurationException' before that clause, so the reported behaviour is unchanged, and nothing else in the package or its tests catches the base class expecting a configuration error. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #105 +/- ##
=======================================
Coverage 80.09% 80.09%
=======================================
Files 7 7
Lines 3456 3456
Branches 410 410
=======================================
Hits 2768 2768
Misses 529 529
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Paebbels
reviewed
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pyEDAA.OutputFilter.CLI.Configuration.ConfigurationExceptionis removed; both modules usepyTooling.Configuration.ConfigurationException.pyTooling has carried a
ConfigurationExceptionfor as long aspyTooling.Configurationhas existed(
pyTooling/Configuration/__init__.py:66). Having a second class of the same name in a package that importspyTooling meant
except ConfigurationExceptiondid different things depending on which one was in scope.Its base is
ToolingException, which provides the notes API thatmain()'s handler already reads throughHasNotes/Notes.Breaking Changes
OutputFilterException. The class now derives fromToolingException, soexcept OutputFilterExceptiondoes not catch it any more.main()is unaffected - it catchesConfigurationExceptionin an earlier clause thanOutputFilterException,so what the user sees is unchanged. Nothing else in the package or its tests catches the base class expecting a
configuration error; I checked before making the change.
For anyone importing it, the path changes from
pyEDAA.OutputFilter.CLI.ConfigurationtopyTooling.Configuration.Others
OutputFilterExceptionimport inCLI/Configuration.pywas left unused by the removal and is dropped.Related Issues and Pull-Requests
its notes and causes.
CLI/__init__.py; merge The service program starts again, and its tests use pyTooling's base class #104 first and I will rebase this one.