Skip to content

Use legacy Git images for pinned CI versions - #396

Merged
JKrag merged 5 commits into
masterfrom
copilot/fix-test-all-container-git-versions
Oct 26, 2026
Merged

JKrag merged 5 commits into
masterfrom
copilot/fix-test-all-container-git-versions

Conversation

Copilot AI commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The container matrix failed before running tests because historical bitnami/git tags, including 2.30.2, were unavailable.

  • Image selection: Keep latest on bitnami/git; use bitnamilegacy/git for pinned versions.
image: ${{ matrix.git_version == 'latest' && 'bitnami/git:latest' || format('bitnamilegacy/git:{0}', matrix.git_version) }}

Co-authored-by: moller2866 <83021349+moller2866@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job test-all-container-git-versions Use legacy Git images for pinned CI versions Oct 16, 2026
Copilot AI requested a review from moller2866 October 16, 2026 11:50
@moller2866

Copy link
Copy Markdown
Contributor

@copilot fix the workflow

Co-authored-by: moller2866 <83021349+moller2866@users.noreply.github.com>

Copilot AI commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix the workflow

Moved checkout onto the hosted runner and now run each Git matrix image with docker run, avoiding the legacy images’ Node 24/glibc incompatibility. All 41 tests pass in each matrix image. Fixed in 4d67031.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@moller2866

Copy link
Copy Markdown
Contributor

Tried simplifying this to the container: keyword with a matrix image, but CI failed for bitnamilegacy/git:2.19.2 and 2.23.0 (latest and 2.30.2 passed). The failure is at actions/checkout, before any tests run:

/__e/node24/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found

With container:, the runner injects its own Node 24 into the image to run JavaScript actions. The old images have a glibc too old for it, so the job fails. Running docker run from the host avoids this: checkout runs on the host, and only test-all.sh runs inside the pinned Git image. I've reverted the simplification (see the revert commit), so the docker run approach is needed here.

The container keyword fails for old images (2.19.2, 2.23.0): the runner's
injected Node 24 needs a newer glibc than these images provide.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@moller2866
moller2866 marked this pull request as ready for review October 26, 2026 10:37
@moller2866
moller2866 requested a review from JKrag October 26, 2026 10:38
@JKrag
JKrag merged commit f0aa825 into master Oct 26, 2026
9 checks passed
@JKrag
JKrag deleted the copilot/fix-test-all-container-git-versions branch October 26, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants