Skip to content

Show sub-GHz CPU frequency in MHz instead of always GHz - #542

Open
vjr wants to merge 1 commit into
mainfrom
vishal/cpu-frequency-mhz
Open

Show sub-GHz CPU frequency in MHz instead of always GHz#542
vjr wants to merge 1 commit into
mainfrom
vishal/cpu-frequency-mhz

Conversation

@vjr

@vjr vjr commented Aug 25, 2026

Copy link
Copy Markdown
Member

No description provided.

@vjr vjr self-assigned this Aug 25, 2026
@vjr
vjr requested review from a team and stsdc August 25, 2026 03:36
@vjr vjr mentioned this pull request Aug 25, 2026
@vjr
vjr requested a review from danirabbit August 25, 2026 03:49

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely moving this to a utility is great. I think we should follow how GLib format_size works here at least for localization. They have great comments and it seems they translate the unit separately from the final string (probably for RTL or languages that don’t use spaces etc) https://github.com/GNOME/glib/blob/main/glib/gutils.c#L2834

@vjr

vjr commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Definitely moving this to a utility is great. I think we should follow how GLib format_size works here at least for localization. They have great comments and it seems they translate the unit separately from the final string (probably for RTL or languages that don’t use spaces etc) https://github.com/GNOME/glib/blob/main/glib/gutils.c#L2834

Kool - can we leave the glib style translation part for another PR? I'm not adept in this area so either someone who can or I can work on it later. Existing main branch also lacks this glib style translation.

@vjr
vjr requested a review from danirabbit August 25, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants