Conversation
eliel9012
commented
May 24, 2026
eliel9012
left a comment
eliel9012
left a comment
Owner
Author
There was a problem hiding this comment.
Font review:
- Good direction: the fix addresses the actual root cause. SwiftUI root
.font(...)does not override explicit child calls like.font(.system(...)),.font(.headline),.font(.title3), etc. Replacing those in the visible screens is necessary. - The Mac OS 9 default UI font should be
Charcoalfor the app chrome and controls. Apple Garamond should stay limited to editorial/display moments, not global UI titles. This PR now follows that. - UIKit appearance is now applied in
MeuLabApp.init(), which is important for navigation/tab bars because appearance proxies need to be configured before the relevant UIKit views are created. - Font registration looks correct:
UIAppFontsincludes Charcoal/Geneva/Apple Garamond and the PostScript names used byMacOS9Typographymatch the bundled files. - Residual risk: SF Symbols still render with Apple system glyphs. That is expected unless custom bitmap/classic icons are introduced later. Text around those icons now uses the Mac OS 9 typography tokens.
Build verified with generic iOS destination.
Owner
Author
|
Update after layout review:
Verification: |
Owner
Author
|
Atualizei este PR com foco no problema de abertura lenta e fonte da Rádio/SDR.
Validação: xcodebuild -project MeuLabApp.xcodeproj -scheme MeuLabApp -destination 'generic/platform=iOS' build passou. |
Ports the feature changes from codex/ia-dashboard-weather onto the Mac OS 9 redesign: - Delete the RemoteRadio (SDR) and Alertas features entirely (views, view model, models, API/WebRTC clients) from both the main app and Watch targets, plus all menu/tab/switch references in ContentView, EnhancedContentView, iPadSplitView, and the Watch content views. - Redirect OpenAlertInMeuLabIntent and IntelligenceView's "Abrir Alertas" affordances to the ADS-B tab instead of the removed Alerts tab. - Add a Mac-OS-9-styled EmptyStateCard to StatCard.swift so RemoteControlView's empty state keeps working after AlertsView.swift (which used to host it) is gone. - Remove the Mac Mini node picker and content from SystemView, leaving only the Pi5 telemetry (AppState's macMini* plumbing is left in place since nothing else depends on removing it). - Add TesouroReservaView and ViagemView as new "Mais" menu screens, restyled with the MacOS9 design system (MacOS9Panel/Screen/TitleBar/ Typography/Colors) while keeping all calculation logic (TREngine, BCB Selic loaders, tax brackets) and all trip itinerary content verbatim. - Register both new screens in project.pbxproj and the tab enum. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Ghosted/doubled text on Tesouro Reserva, Viagem, and the Mac OS 9
stat-card/button components: several call sites applied .shadow()
to a whole content-bearing container (text included) instead of to
the background shape alone. With radius:0 and an opaque dropShadow
color, SwiftUI renders a hard-edged duplicate silhouette of every
glyph underneath the real one — i.e. exactly the doubled-text look.
Fixed by scoping each shadow to its background layer, matching the
pattern the design system's own mac9Panel()/mac9Window() modifiers
already used correctly. Also removed the one MacOS9Typography.bodyBold
synthetic-bold (.weight(.bold) on a custom font with no real bold
face), which was contributing to the same ghosting.
Aircraft photos ("Sem foto disponível" everywhere): same root cause
already fixed on codex/ia-dashboard-weather — PlaneSpotters.net now
rejects requests without a descriptive User-Agent. Applied the same
fix to this branch's copy of AircraftPhotoView (embedded in
ADSBView.swift — the standalone Components/AircraftPhotoView.swift
and PlaneSpottersView.swift were dead files, never registered in the
Xcode project) and removed those two orphaned duplicates.
Finished the notification-backlog fix that was left uncommitted when
the previous session hit its usage limit mid-task.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font review
This PR fixes the Mac OS 9 typography pass. The previous global
.mac9Theme()font was not enough because many SwiftUI views explicitly set.system,.headline,.title,.caption, rounded, or monospaced fonts. Those explicit calls override the root environment font.What changed
MeuLabApp.init()so navigation/tab bars pick up the theme before rendering.Charcoalas the standard Mac OS 9 UI font for navigation bars, tab bar labels, app text, chips, cards, and main screen labels.Mais,Bíblia,Clima, andADS-B.Review notes
UIAppFontsand included in the Xcode resources.Charcoal.ttfresolves to PostScript nameCharcoal;Geneva.ttfresolves toGenevaPlain; Apple Garamond names also resolve correctly.Verification
xcodebuild -project MeuLabApp.xcodeproj -scheme MeuLabApp -destination 'generic/platform=iOS' build\n- Build succeeded.\n\n### Secret safety\n- No.env, tokens,Secrets.plist,Secrets.xcconfig, or Swift secrets were staged.