refactor(pi): PathResolver::new takes a required home argument - #212
Open
ecalifornica wants to merge 1 commit into
Open
refactor(pi): PathResolver::new takes a required home argument#212ecalifornica wants to merge 1 commit into
ecalifornica wants to merge 1 commit into
Conversation
ecalifornica
changed the title
|
🔍 Preview deployed: https://acb3485a.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-pi
branch
from
August 14, 2026 19:49
23a6b5a to
dac6555
Compare
ecalifornica
marked this pull request as ready for review
August 17, 2026 18:06
toolpath-pi reads no environment variable. The caller supplies the home directory. The crate keeps the layout below it: Pi session logs are in <home>/.pi/agent/sessions. - PathResolver::new(home) takes the home directory as a required argument. PiConvo::new(home) takes the same argument. - Deleted: the Default impls on PathResolver and PiConvo, PathResolver::with_home, and the $HOME read. - with_sessions_dir stays as the full override. It beats the home argument. - The resolver does not consult the current working directory. The ./.pi/agent/sessions fallback is gone. path-cli: - providers::pi_resolver returns Option<PathResolver>. None means the configuration carries no home directory. - harness_bundle omits the Pi manager when the resolver is None. - providers::require_pi_resolver turns None into an error. The 5 commands that target Pi use it.
ecalifornica
force-pushed
the
robert/config-pi
branch
from
August 18, 2026 20:09
dac6555 to
599c9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #185: the crate reads no environment variable,
Configowns every read, and the caller supplies what the crate used to resolve itself.Judgment calls:
$HOME-only read is gone, andConfig::home_dir()falls back to$USERPROFILE, so Windows home resolution needs no patch in the crate.--basechainswith_sessions_dironto the resolver, so it wins against the home argument. The resolver holds one field, the effective sessions directory; home is fixed at construction, so there is no cached recompute and no override flag.