refactor(github): the caller supplies the API token - #213
Open
ecalifornica wants to merge 1 commit into
Open
Conversation
|
🔍 Preview deployed: https://32c1b3ab.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-github-token
branch
from
August 14, 2026 19:49
5b3365c to
7413348
Compare
ecalifornica
marked this pull request as ready for review
August 17, 2026 18:08
ecalifornica
commented
Aug 17, 2026
| "CODEX_ROLLOUT_STRICT", | ||
| "COPILOT_EVENTS_STRICT", | ||
| "COPILOT_HOME", | ||
| "GITHUB_TOKEN", |
Collaborator
Author
There was a problem hiding this comment.
This will be refactored.
toolpath-github drops resolve_token. DeriveConfig.token is the only token input, so the crate reads no environment variable and runs no subprocess. path-cli resolves the token at the composition root. Config reads $GITHUB_TOKEN, and providers::github_token prefers that value over the 'gh auth token' fallback. p import github and p list github take the token from there, so both keep their behavior for CLI users.
ecalifornica
force-pushed
the
robert/config-github-token
branch
from
August 18, 2026 20:10
7413348 to
cf004f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186. GitHub is a remote source: the crate's input is an API token, not a resolver.
DeriveConfig.tokenalready carries it, soresolve_tokenleaves the crate, the crate reads no environment variable and runs no subprocess, and the caller owns where the token comes from.Judgment calls:
gh auth tokensubprocess stays a live call below the composition root, inproviders::github_token. Running a program is execution environment, not configuration, so it is not aConfigfield. Only the$GITHUB_TOKENread moves toConfig.providers::github_tokenkeeps the deletedresolve_tokenprecedence exactly: the configured value when set and not empty, else the token the GitHub CLI holds. Error messages stay the same, so the variable and theghfallback keep their behavior for CLI users.providers::github_token_or_elseexists as a seam so the precedence (configured value wins, empty string falls through) is unit-tested without runninggh.https://pathbase.dev/u/ecalifornica/pathstash/graphs/80e149fb-206b-4223-b591-4ebc1373f13c
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.