Fix trace_sampled MDC flag for micrometer+OTel starter (PR 451) - #452
Merged
Conversation
…est, fix TraceSampledMdcHandler Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>
Copilot
AI
changed the title
Fix PR 451: autodetect micrometer+OTel starter, add trace_sampled test, fix TraceSampledMdcHandler
Fix trace_sampled MDC flag for micrometer+OTel starter (PR 451)
Aug 15, 2026
Copilot created this pull request from a session on behalf of
skjolber
August 15, 2026 00:01
View session
skjolber
marked this pull request as ready for review
August 15, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TraceSampledMdcHandlerwas placed in test sources (no-op in production) and used@ConditionalOnBean(Tracer.class)on a component-scanned@Configuration— which always fails because component-scan conditions are evaluated before autoconfiguration creates theTracerbean.Key fixes
TraceSampledMdcHandler— moved to main, fixed registrationsrc/test→src/mainso it actually runs in the application@BeaninLogConfiguration(not@Component) usingObjectProvider<Tracer>— resolves lazily at instantiation time, safe when tracing is disabled@Conditional(NoOpenTelemetryAgentCondition.class)— handler is skipped when the OTel Java agent is attached; the agent uses different MDC keys handled byStackdriverOpenTelemetryTraceMdcJsonProviderapplication.propertiesmanagement.tracing.enabled=trueandmanagement.tracing.sampling.probability=1.0WebLoggingFormatTestlogging.googleapis.com/trace_sampled: trueon every captured log statement, verifying the full chain:TraceSampledMdcHandler→ MDCtraceSampled→StackdriverMicrometerTraceMdcJsonProvider→ JSON boolean fieldLogStatement(test utility)getJsonPropertyBoolean(String name)for reading boolean JSON fields from captured log eventsspring-boot-autoconfigure-gcpimplementation 'io.micrometer:micrometer-tracing'— nothing in this module uses it