Skip to content

feat(gcp): move TraceSampledMdcHandler into spring-boot-autoconfigure-gcp - #453

Merged
skjolber merged 1 commit into
opentelemetryfrom
copilot/move-tracesampledmdchandler-to-spring-boot-autocon
Aug 15, 2026
Merged

feat(gcp): move TraceSampledMdcHandler into spring-boot-autoconfigure-gcp#453
skjolber merged 1 commit into
opentelemetryfrom
copilot/move-tracesampledmdchandler-to-spring-boot-autocon

Conversation

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

TraceSampledMdcHandler was hand-wired in the OTel-starter example's LogConfiguration, requiring every consumer to copy-paste it. Move it into the autoconfigure module so it is provided automatically.

Changes

gcp/spring-boot-autoconfigure-gcp

  • New TraceSampledMdcHandler — writes traceSampled MDC key consumed by StackdriverMicrometerTraceMdcJsonProviderlogging.googleapis.com/trace_sampled
  • New GcpMicrometerTraceAutoConfiguration — both suppression conditions applied at class level so the entire configuration is skipped as a unit:
    • @ConditionalOnClass(Tracer.class) — no-op when micrometer-tracing is absent
    • @Conditional(NoOpenTelemetryAgentCondition.class) — no-op when OTel Java agent is attached (agent owns MDC)
    • @AutoConfiguration(afterName = "...TracingAutoConfiguration")Tracer bean is resolved before this config is processed
  • io.micrometer:micrometer-tracing added as compileOnly (not propagated to consumers)
  • Registered in AutoConfiguration.imports

examples/gcp-web-without-test-artifacts-otel-starter-example

  • Removed manual TraceSampledMdcHandler bean and its imports from LogConfiguration

examples/gcp-web-without-test-artifacts-otel-agent-example

  • Added TraceSampledMdcHandlerAbsenceTest — asserts traceSampledMdcHandler bean is absent when agent is active (uses name-based lookup; micrometer-tracing is not on this module's classpath)

…th @AutoConfigureAfter and class-level conditions

Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>
Copilot AI changed the title feat: move TraceSampledMdcHandler to spring-boot-autoconfigure-gcp (stacked on #450) feat(gcp): move TraceSampledMdcHandler into spring-boot-autoconfigure-gcp Aug 15, 2026
Copilot AI requested a review from skjolber August 15, 2026 10:47
@skjolber
skjolber changed the base branch from main to opentelemetry August 15, 2026 14:23
@skjolber
skjolber marked this pull request as ready for review August 15, 2026 14:40
@skjolber
skjolber requested review from a team as code owners August 15, 2026 14:40
@skjolber
skjolber merged commit dbfb69b into opentelemetry Aug 15, 2026
10 checks passed
@skjolber
skjolber deleted the copilot/move-tracesampledmdchandler-to-spring-boot-autocon branch August 15, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants