Repository navigation
Conversation
For legacy clients that only support server-time, the spec says: "Servers MAY include the timestamp in messages when they see fit but MUST NOT do so before acknowledging the client capability using CAP ACK." This is legacy behavior from before the ratification of message-tags, but if the client didn't request message-tags or another dependent spec, we should respect it.
Member
Author
|
Sonnet 5.5 reviewed this and found no functional issues (but it did flag a mistaken comment). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this up for reference/discussion. This fixes #2460 according to my understanding of the issue, e.g.
but I'm not sure if I want to merge it; it makes the code more complex to the benefit of (AFAICT) no real clients.