Fix join directive - #1
Open
colophonemes wants to merge 1 commit into
Open
colophonemes wants to merge 1 commit into
colophonemes wants to merge 1 commit into
Conversation
Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself
Owner
|
Thanks. The underlying issue is this thing was never updated from pre-1.0.0 metalsmith... I'm surprised it still works at all! It looks like the API was changed from But that would mean testing it on a newer version of metalsmith and updating package.json. Would you be up for doing that? I'm afraid I don't use metalsmith much anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself