Repository navigation
chore: add LICENSE, CI, Cargo metadata, fix clippy warnings - #1
Merged
Merged
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
eunhhu
added a commit
that referenced
this pull request
Oct 26, 2026
chore: add LICENSE, CI, Cargo metadata, fix clippy warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
penput was already in solid shape — a usable README, a release workflow, and clean module structure. This PR fills in the gaps a polished crate is expected to have without changing any runtime behaviour.
Polish
LICENSE.Cargo.tomldeclaredlicense = "MIT"but there was no matching file. Added the standard MIT text.authors,repository,homepage,readme,keywords,categories, andrust-version = "1.88". The MSRV was implicit (let-chains +edition = "2024"); now it's explicit socargo install penputon an older toolchain fails with a clear message.CI
ci.yml. The existingrelease-build.ymlonly runs when the commit message containsrelease, so regular PRs had no sanity check. Added a lint-and-build workflow that runs on every push / PR:cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo buildlibxcb1-dev/libx11-devso enigo links on the Ubuntu runner.Cleanups (to make
-D warningspass)src/connection.rs—print!("...\n")→println!("...")(clippyprint_with_newline).src/websocket.rs,src/udp.rs— collapsed nestedif let … { if … }blocks into let-chains (clippycollapsible_if). Bumping MSRV to 1.88 covers this.src/http.rs—cargo fmtre-ordered some imports; no logic change.Review & Testing Checklist for Human
cargo run -- --port 8080 --ws-port 9001, approve a connection in the CLI, and confirm the mobile touchpad still drives the mouse as before.cargo clippy --all-targets -- -D warningsis clean locally.Notes
udp.rs/websocket.rsare literal semantic equivalents of the previous nestedif let … { if … }blocks.rust-versionwas set to1.88specifically because that is the release that stabilisedif let-chains.Link to Devin session: https://app.devin.ai/sessions/3e6146e428b74cc6bc973143697be3eb
Requested by: @eunhhu