Repository navigation
chore: add LICENSE, PR-time CI, Cargo metadata; fix README placeholders; cargo fmt - #12
Merged
Merged
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
eunhhu
self-requested a review
April 24, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills in the missing "published crate" hygiene. No runtime behaviour change — the biggest chunk of diff is a project-wide
cargo fmt --allto make the new CI's format check pass.Licensing
LICENSE.Cargo.tomldeclaredlicense = "MIT"but no file was checked in. Added the standard MIT text.[Add your license information here]) — replaced with a link toLICENSE.Cargo metadata
Added
authors,repository,homepage,readme,keywords,categories, andrust-version = "1.70"to[package]. This makescargo publishproduce a useful crates.io page instead of a stub.CI
.github/workflows/ci.yml. The only existing workflows (release.yml,publish-crates.yml) run on git tags, so regular PRs got zero automated validation. The new workflow runs on every push/PR:libclang-dev/clangsofrida-sys' bindgen build can find libclang.cargo fmt --all -- --checkcargo clippy --all-targets(does NOT pass-D warnings— the pre-existing tree has 28 warnings; tightening is a separate cleanup).cargo buildcargo test --all(all 18 existing unit tests pass).README polish
your-usernameplaceholders in clone URL and issues link witheunhhu.Formatting
cargo fmt --all. Only touchessrc/gum/commands/*.rs,src/gum/memory.rs,src/gum/store.rs,src/gum/vzdata.rs. Pure formatting; no logic changes.Review & Testing Checklist for Human
src/gum/commands/disasm_cmds.rsandsrc/gum/memory.rs).cargo build && cargo teststill passes locally (mirrors what CI does).Notes
release.yml/publish-crates.ymlworkflows are unchanged; they continue to run only onv*.*.*tags.Link to Devin session: https://app.devin.ai/sessions/3e6146e428b74cc6bc973143697be3eb
Requested by: @eunhhu