fix(release): support Windows release builds - #404
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow no longer applies native CPU optimizations when building release binaries for matrix targets. ChangesRelease builds
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to Release builds now use Cargo's portable defaults rather than host-native CPU flags, enabling the Windows workflow command while avoiding host-specific binaries. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description accurately explains the workflow change and its Windows build impact, but it omits the required type of change, related issue, checklist, testing details, and additional notes sections.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes the POSIX-only inline RUSTFLAGS assignment from the cross-platform release build step. The assignment is parsed as a command by PowerShell, causing Windows release builds to fail before Cargo starts. Removing target-cpu=native also avoids producing host-CPU-specific release binaries.
Summary by CodeRabbit