Skip to content

fix(release): support Windows release builds - #404

Merged
tac0turtle merged 1 commit into
mainfrom
fix/release-windows-shell
Sep 10, 2026
Merged

fix(release): support Windows release builds#404
tac0turtle merged 1 commit into
mainfrom
fix/release-windows-shell

Conversation

@tac0turtle

@tac0turtle tac0turtle commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Removes the POSIX-only inline RUSTFLAGS assignment from the cross-platform release build step. The assignment is parsed as a command by PowerShell, causing Windows release builds to fail before Cargo starts. Removing target-cpu=native also avoids producing host-CPU-specific release binaries.

Summary by CodeRabbit

  • Chores
    • Standardized release builds across supported targets for more consistent binary output.

@tac0turtle
tac0turtle requested a review from a team as a code owner September 10, 2026 09:15
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f7440723-7b08-4c92-ada8-0f8fa5c19cf7

📥 Commits

Reviewing files that changed from the base of the PR and between 9bcc189 and 402fc95.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow no longer applies native CPU optimizations when building release binaries for matrix targets.

Changes

Release builds

Layer / File(s) Summary
Portable release build command
.github/workflows/release.yml
The build-release job removes the RUSTFLAGS="-C target-cpu=native" override from the release build step.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: auricom

Merge Risk: ⚪ Minimal · up to 402fc

Release builds now use Cargo's portable defaults rather than host-native CPU flags, enabling the Windows workflow command while avoiding host-specific binaries. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description accurately explains the workflow change and its Windows build impact, but it omits the required type of change, related issue, checklist, testing details, and additional notes sections… Add the required template sections. Select the applicable change type, provide a related issue or state that none applies, complete the checklist, and describe the tests run, including Windows release-build validation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: enabling Windows release builds by fixing the release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description accurately explains the workflow change and its Windows build impact, but it omits the required type of change, related issue, checklist, testing details, and additional notes sections.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-windows-shell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tac0turtle
tac0turtle merged commit d1d37d1 into main Sep 10, 2026
15 checks passed
@tac0turtle
tac0turtle deleted the fix/release-windows-shell branch September 10, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant