Repository navigation
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ritval The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @Ritval! It looks like this is your first PR to falcosecurity/charts 🎉 |
The Falcosidekick pods always mount their ServiceAccount's API token, though only the kubeless, openfaas, fission and policyreport outputs call the Kubernetes API. The new value lets a deployment without those outputs run without the token. It defaults to true, so rendered behaviour is unchanged unless it is set to false. Signed-off-by: Klas Blomgren <klas@playgroundtech.io>
Ritval
force-pushed
the
falcosidekick-automount
branch
from
November 16, 2026 15:10
7adb73b to
48879ad
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Adds
automountServiceAccountTokento the Falcosidekick v2 chart (charts/falcosidekick-v2) and sets it on the Falcosidekick pod spec.Today the Falcosidekick pods always mount their ServiceAccount's API token, though only the kubeless, openfaas, fission and policyreport outputs call the Kubernetes API. Clusters that harden workloads (for example by requiring pods that never call the API to run without a token) can't do that for Falcosidekick, because the chart creates the ServiceAccount under a fixed name and has no setting for it.
The value defaults to
true, so nothing changes unless it is set tofalse. Only the core Falcosidekick Deployment gets the setting; the Web UI pods are left as they are.Which issue(s) this PR fixes:
None filed.
Special notes for your reviewer:
Released as 0.14.4 so it stays inside the
0.14.*range the falco chart depends on (the v3 chart already mounts the token only for the policy report output).Rendered with
--set automountServiceAccountToken=false(the field isfalseon the Falcosidekick Deployment),trueand unset (bothtrue). Apart from the new field, the default render matches master except the config checksum, which follows the chart version label.helm lintpasses; README regenerated with helm-docs v1.11.0.Checklist