Clarify SSH auth is only for crate registry index, overall cleanup - #73
Merged
Conversation
tlater-famedly
previously approved these changes
Aug 15, 2025
tlater-famedly
left a comment
tlater-famedly
left a comment
Contributor
There was a problem hiding this comment.
I like it, if we're doing breaking changes anyway might as well update the secret name.
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
3 times, most recently
from
September 10, 2025 12:20
49014c9 to
d0a0a6e
Compare
chgrv
marked this pull request as ready for review
September 10, 2025 12:21
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
from
September 10, 2025 12:28
d0a0a6e to
e20baed
Compare
chgrv
changed the title
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
from
September 10, 2025 13:39
f9c8726 to
591649e
Compare
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
from
September 10, 2025 13:43
591649e to
e62d179
Compare
skomski
reviewed
Sep 10, 2025
skomski
previously approved these changes
Sep 11, 2025
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
from
September 11, 2025 13:17
0b1997f to
d2a2c21
Compare
jannden
previously approved these changes
Sep 11, 2025
jannden
left a comment
jannden
left a comment
Contributor
There was a problem hiding this comment.
Nice, finally getting rid of Gitlab legacy 🥳
sirewix
reviewed
Sep 11, 2025
sirewix
reviewed
Sep 11, 2025
sirewix
reviewed
Sep 12, 2025
sirewix
previously approved these changes
Sep 12, 2025
chgrv
force-pushed
the
egraven/remove-gitlab-and-ssh-auth
branch
from
September 12, 2025 13:13
6e11a33 to
5e41690
Compare
sirewix
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/famedly/team-workflows/issues/76
Closes #21