fix: preserve reports for duplicate basenames - #39
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Problem
Closes #24.
Reports were named only from the source basename, so files such as
pkg_a/user.pyandpkg_b/user.pyoverwrote each other and left duplicate links insummary.md.Changes
Tests
.venv\\Scripts\\python.exe -m pytest --basetemp=.pytest-tmp-full tests/ -q— 1 passed..venv\\Scripts\\python.exe -m py_compile setup.py insight\\__init__.py insight\\analyzer.py insight\\cli.py insight\\detector.py insight\\reporter.py insight\\utils.py— passed..venv\\Scripts\\python.exe -c "import insight"— passed.tests\\test_reporter.py— passed.insight\\reporter.pywith the pre-existingI001finding excluded — passed.Compatibility / Known limitations
The report contents and summary metrics are unchanged; only report filenames and corresponding links are made path-specific. The upstream baseline currently reports existing Ruff findings, including the historical formatting/import finding in
insight/reporter.py; no unrelated cleanup is included here.Issue link
#24