Add active FTB Ranks lookup for online players. Fixes bug in SDLink where conditon ranks in FTB Teams do not work. - #36
Merged
Conversation
Added comments to clarify the purpose of methods related to player ranks.
Updated comments for clarity and removed unused import.
hypherionmc
requested changes
Jul 5, 2026
Uncommented based on PR change request for compatability
hypherionmc
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for querying a player's active FTB Ranks, including ranks granted by conditions.
Currently, getPlayerRanks(CraterGameProfile) uses RankManager.getAddedRanks(...), which only returns explicitly assigned ranks. This means integrations cannot detect ranks granted by FTB Ranks conditions.
Changes
Added getPlayerRanks(CraterPlayer) to the FTB Ranks compatibility API.
Implemented the new method using RankManager.getRanks(ServerPlayer) to return all active/effective ranks.
Added hasRank(CraterPlayer, String) for checking active ranks.
Preserved the existing CraterGameProfile methods for backward compatibility and for integrations that work with explicitly assigned ranks.
Tested
Verified that getPlayerRanks(CraterPlayer) returns condition-based ranks that are not present in getAddedRanks(...).