Skip to content

Expand reddit_ads version range to include v1.6.0 - #189

Merged
fivetran-catfritz merged 6 commits into
mainfrom
feature/update-reddit-ads-column-deprecation-in-ad-reporting
Sep 30, 2026
Merged

fivetran-catfritz merged 6 commits into
mainfrom
feature/update-reddit-ads-column-deprecation-in-ad-reporting

Conversation

@julianarombo

@julianarombo julianarombo commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Expands the supported reddit_ads package range from [">=1.5.0", "<1.6.0"] to [">=1.5.0", "<1.7.0"] so Ad Reporting picks up reddit_ads v1.6.0.
  • reddit_ads v1.6.0 removes the deprecated optimization_strategy_type field from stg_reddit_ads__ad_group and is_processing from stg_reddit_ads__ad. Neither field is used in any ad_reporting models, so the impact is limited to users selecting them directly from the Reddit staging models.
  • Updates the README dependency snippet and the install range to v2.8.0, and adds the Reddit changes to the existing v2.8.0 CHANGELOG entry.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR (none)

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@julianarombo julianarombo added the docs:ready Triggers the docs generator workflow. label Sep 30, 2026
@julianarombo
julianarombo marked this pull request as ready for review September 30, 2026 20:28
Comment thread README.md Outdated
Comment thread packages.yml Outdated
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-data-model-bot fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 30, 2026
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Sep 30, 2026
@fivetran-catfritz
fivetran-catfritz enabled auto-merge (squash) September 30, 2026 21:07
@fivetran-catfritz
fivetran-catfritz merged commit 03880ed into main Sep 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants