Conversation
Contributor
|
@soonhyo nice!, btw did HIRO ues fkanehiro/master branch? |
Author
HIRO uses pazeshun/hrpsys-base’s hironxjsk-devel branch. I’ve closed this PR and opened two new PRs: one targeting fkanehiro/master (#1342 ) and another targeting hironxjsk-devel (pazeshun#1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On HIRO running QNX, partial serial reads could leave bytes from a previous transaction and cause subsequent requests to fail across servo IDs. Synchronous packet dumps also delayed service calls.
This PR:
retaining error messages.
Service signatures are unchanged. C++ consumers of ServoSerial.h must rebuild.
Regression tests passed with logging enabled and disabled.
Corresponding changes were tested on HIRO running QNX.
The protocol still cannot distinguish a late reply to an identical request.