Skip to content

CMakelists.txt: Stop using Make automatic variable - #61

Closed
nikomauno wants to merge 1 commit into
fluent:masterfrom
nikomauno:master-stop-using-automatic-make-variable
Closed

nikomauno wants to merge 1 commit into
fluent:masterfrom
nikomauno:master-stop-using-automatic-make-variable

Conversation

@nikomauno

Copy link
Copy Markdown
Contributor

CMake Makefile layout generation has changed since version 3.20, ref: https://discourse.cmake.org/t/base-filename-gets-set-to-compiler-depend-ts-after-update-to-cmake-3-20/3075/4

For instance with Yocto framework this approach can lead to QA issue stemming from build host path ending up in generated binary like

ERROR: fluentbit-3.1.9-r0 do_package_qa: QA Issue: File /usr/bin/fluent-bit in package fluentbit contains reference to TMPDIR [buildpaths]
ERROR: fluentbit-3.1.9-r0 do_package_qa: Fatal QA errors were found, failing task.

stemming from

  $ strings packages-split/fluentbit/usr/bin/fluent-bit
  ...
  $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<))
  ...

--

On related note, I was inspired to open this pull request by feedback from Fluent Bit project maintainer in fluent/fluent-bit#9450 (comment)

CMake Makefile layout generation has changed since version 3.20, ref:
https://discourse.cmake.org/t/base-filename-gets-set-to-compiler-depend-ts-after-update-to-cmake-3-20/3075/4

For instance with Yocto framework this approach can lead to QA issue
stemming from build host path ending up in generated binary like

  ERROR: fluentbit-3.1.9-r0 do_package_qa: QA Issue: File /usr/bin/fluent-bit in package fluentbit contains reference to TMPDIR [buildpaths]
  ERROR: fluentbit-3.1.9-r0 do_package_qa: Fatal QA errors were found, failing task.

stemming from

  $ strings packages-split/fluentbit/usr/bin/fluent-bit
  ...
  $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<))
  ...

Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
@edsiper

edsiper commented Oct 8, 2026

Copy link
Copy Markdown
Member

superseded by PR #92 (#92), merged July 13, 2026. #92 preserves #61’s original fix and authorship, then adds a library-specific CTR_FILENAME macro to avoid collisions with other bundled
libraries.

@edsiper edsiper closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants