Repository navigation
feat(fluentd): add metrics.serviceMonitor.path value - #758
Merged
stevehipwell merged 2 commits intoOct 7, 2026
Merged
Conversation
yakir-shriker
requested review from
patrick-stephens and
stevehipwell
as code owners
October 1, 2026 12:19
stevehipwell
requested changes
Oct 2, 2026
stevehipwell
left a comment
stevehipwell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR @yakir-shriker, please see my review comments. You will also need to rebase.
The ServiceMonitor hardcodes path /metrics, which only returns worker 0 when Fluentd runs with multiple workers. Make the path configurable so /aggregated_metrics can be scraped instead. Default is unchanged. Signed-off-by: Yakir Shriker <yakirshr@gmail.com>
Signed-off-by: Yakir Shriker <yakirshr@gmail.com>
Contributor
Author
|
Thanks @stevehipwell! Applied both suggestions and rebased on main. |
yakir-shriker
force-pushed
the
fluentd-servicemonitor-path
branch
from
October 4, 2026 07:57
65b7f10 to
02d2891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #757.
The ServiceMonitor hardcodes
path: /metrics, which only returns worker 0 when running multiple workers. This addsmetrics.serviceMonitor.path(default/metrics) so/aggregated_metricscan be scraped.Rendered output is identical to
mainwhen the value is unset.just docsclean)[UNRELEASED],just lintclean