Migrate devtools tool skill validation to new dart_skills_lint API#9899
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dart_skills_lint dependency to version 0.4.0 (updating its git ref in pubspec.lock and tool/pubspec.yaml) and updates meta to 1.19.0. It also modifies tool/test/validate_skills_test.dart to use absolute paths resolved via pathFromRepoRoot for the configuration file and skills directory, and updates the validateSkills call to disable the check-absolute-paths rule. Minor formatting adjustments are made in tool/cpu_sample_intervals.dart and tool/json_to_map.dart. There are no review comments, and I have no feedback to provide.
2daecef to
e57ef51
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the dart_skills_lint dependency to version 0.4.0 by updating its git ref in tool/pubspec.yaml and pubspec.lock. Additionally, the meta package is updated to version 1.19.0 in pubspec.lock. There are no review comments, and I have no feedback to provide.
3 participants
Bumps the pinned
dart_skills_lintdependency ref to the latest main commit.This latest commit allows setting parameters on rules which is important for some flavors of evals as the non tracked artifacts will cause the linter to throw false positives.