Repository navigation
Conversation
Metrics series for a Bucket, GitRepository, HelmChart, HelmRepository or OCIRepository are only dropped by the deferred RecordDuration call, and only on a reconcile pass that observes the object with its deletion timestamp set and the owned finalizer already removed. Reconcile returns at the client.Get NotFound check before that defer is registered, so an object whose last observed state is NotFound keeps its gotk_reconcile_duration_seconds series in the registry until the controller process restarts. Same leak as kustomize-controller's Kustomization reconciler, same fix, applied to all five source-controller reconcilers: drop the series on the NotFound path, where the object is known to be gone. Metrics.MetricsRecorder already exposes DeleteDuration(ref) taking a bare object reference -- no live object or new fluxcd/pkg API needed. Includes a deterministic test per reconciler, each driving two Reconcile calls against a fake client: the series survives without this fix and is removed with it. Signed-off-by: Wei-Chen Chen <zarcen@gmail.com> Signed-off-by: Wei-Chen Chen <weichen.chen@omniva.com> Assisted-by: claude-code/claude-sonnet-5
zarcen
marked this pull request as draft
October 13, 2026 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fluxcd/kustomize-controller#1769
Drop a GitRepository/HelmChart/HelmRepository/OCIRepository/Bucket's
gotk_reconcile_duration_secondsseries on the
NotFoundbranch ofReconcile, not only when a reconcileobserves the finalizer being removed.
Metrics.MetricsRecorder.DeleteDurationalready takes a bare object reference, so no new
fluxcd/pkgAPI is needed.One bug, one fix, applied uniformly across all five reconcilers.
Test plan:
go test ./internal/controller/ -run 'Reconciler_deleteMetricsOnNotFound'fails on
main, passes with this change.Related PRs