Skip to content

Add PHP 8.5 package list - #58

Merged
lubien merged 1 commit into
mainfrom
php-8.5
Nov 10, 2026
Merged

lubien merged 1 commit into
mainfrom
php-8.5

Conversation

@lubien

@lubien lubien commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Problem

The generated Dockerfile does ADD .fly/php/packages/${PHP_VERSION}.txt, but the generator only writes package lists for PHP 7.4 through 8.4. Apps on PHP 8.5 fail to build.

Fix

Add 8_5_txt (the 8.4 list for 8.5) and write it to .fly/php/packages/8.5.txt. The ondrej PPA ships every package on the list for jammy.

Tests

By hand: in a fresh laravel/laravel app requiring PHP ^8.5, running php dockerfile-laravel generate from this branch writes .fly/php/packages/8.5.txt. The Dockerfile then builds with PHP_VERSION=8.5, and the container runs PHP 8.5.12 and serves the welcome page (HTTP 200).

Release

composer require --dev fly-apps/dockerfile-laravel installs the committed phar (builds/dockerfile-laravel), so this reaches fly launch only after the phar is rebuilt (php dockerfile-laravel app:build) and a new version is tagged, as with 1.0.9.

The Dockerfile installs the packages listed in .fly/php/packages/${PHP_VERSION}.txt, which only existed up to 8.4, so apps on PHP 8.5 failed to build. The ondrej PPA ships the same packages for 8.5 on jammy.
@lubien lubien self-assigned this Nov 9, 2026
@lubien
lubien marked this pull request as ready for review November 10, 2026 17:35
@lubien
lubien merged commit be2e480 into main Nov 10, 2026
2 checks passed
@lubien
lubien deleted the php-8.5 branch November 10, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant