fix(doc): recover legacy text box stories - #180
Merged
Conversation
Fixes #171 by parsing ccpTxbx/ccpHdrTxbx story text, suppressing placeholder control characters, and preserving readable fallback colors. Adds the reported DOC file as a regression fixture.
Closed
Member
|
Thanks for the sample-backed fix. The exact fixture, DOC regressions, full demo build, and browser smoke all pass locally; ready after the private-source sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171.
The reported legacy
.docis not suffering from a Chinese code-page failure. Its main Word story contains 220x08text-box placeholder characters, while the actual resume text is stored in theccpTxbxtext-box story. The parser previously read onlyccpText, so those placeholders were rendered as square glyphs.Changes
FibRgLwccpTxbxandccpHdrTxbxtext when they contain visible contentMSDOC_TEXTBOX_STORY_LINEARIZEDso callers can identify the fidelity fallbackVerification
tsc -b packages/renderers/doc/tsconfig.jsonnode packages/renderers/doc/scripts/verify-table-spec.mjsnode packages/renderers/doc/scripts/verify-github-34.mjsnode packages/renderers/doc/scripts/verify-github-87.mjsnode packages/renderers/doc/scripts/verify-github-171.mjsThe reported file now yields 28 visible paragraphs, includes
北京,求职意向,教育背景, and实习经历, contains noU+0008placeholder glyphs, and produces no invisible white-on-white fallback text.