Repository navigation
Validate field tracing step-size bounds before integration - #1385
Open
agourakis82 wants to merge 1 commit into
Open
agourakis82 wants to merge 1 commit into
agourakis82 wants to merge 1 commit into
Conversation
Reject invalid step limits, bound initial steps and honor the configured full-box adaptive minimum in both tracing directions. Preserve fixed-step Euler behavior below the adaptive minimum. Add standalone float/double regression tests. LLM-offload-review: provider: darwin-llm/coder-next; task: review; issue: use existing MPI-wide abort_mpi for invalid bounds.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1256.
Reject non-finite, non-positive or inverted tracer step limits before integration, and bound the four initial step sizes. Use the configured full-box minimum in both tracing directions while preserving fixed-step Euler below the adaptive minimum. Default values and integration formulas are unchanged.
Validation on the cluster with GCC 15.2 and Open MPI 5.0.7:
Ionosphere_smallfixture and completed its tracing. An invalidtracer_min_dxwas rejected with a clear diagnostic.The fixture runs used
timestep_max=0to exercise initialization; the full 40-step reference comparison was not run. The standalone tests are not yet wired into CI. C++20 syntax compatibility was checked separately.