Skip to content

chore: Bump torch version pin to allow 2.13 - #209

Merged
andrea-fasoli merged 1 commit into
foundation-model-stack:mainfrom
Daniel-Schenker:torch-2.13-upgrade
Sep 9, 2026
Merged

chore: Bump torch version pin to allow 2.13#209
andrea-fasoli merged 1 commit into
foundation-model-stack:mainfrom
Daniel-Schenker:torch-2.13-upgrade

Conversation

@Daniel-Schenker

Copy link
Copy Markdown
Contributor

Description of the change

This PR bumps the max allowed torch version pin in pyproject.toml to include torch 2.13.

Related issues or PRs

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <email@domain.com>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

Signed-off-by: Daniel-Schenker <daniel.schenker@ibm.com>
@andrea-fasoli

Copy link
Copy Markdown
Collaborator

looking into this

@andrea-fasoli

Copy link
Copy Markdown
Collaborator

Tests were successful using torch 2.13 BUT one FP8 test was skipped because right now I don't have access to hardware supporting real FP8 compute. The skipped test is test_fp8_op in test_fp8_addon.py. I don't expect this to fail and FP8 is not being tested on CICD, but we should make sure, of course. I should regain access to a suitable GPU after Labor Day and we can complete the testing and move this upgrade forward.

On the other hand, I anticipate some adjustments to FP8 will be needed when upgrading torchao beyond 0.11.

cc: @chichun-charlie-liu @nwang-ibm @gkumbhat

@andrea-fasoli andrea-fasoli changed the title Bump torch version pin to allow 2.13 chore: Bump torch version pin to allow 2.13 Sep 4, 2026
@github-actions github-actions Bot added the chore label Sep 4, 2026
@andrea-fasoli

Copy link
Copy Markdown
Collaborator

I confirm the remaining test (test_fp8_op) passes in torch 2.13.
CICD fails due deprecation warnings of some torch quantization functions. These warning are addressed by PR #211 (to be reviewed). After merging this we can bump torch version to 2.13.

@andrea-fasoli andrea-fasoli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving version bump to torch 2.13

@andrea-fasoli andrea-fasoli reopened this Sep 9, 2026
@andrea-fasoli
andrea-fasoli merged commit 8b29558 into foundation-model-stack:main Sep 9, 2026
18 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants