Skip to content

docs: simplify deployment contract - #161

Merged
frankekn merged 2 commits into
mainfrom
chore/simplify-deploy-contract
Sep 19, 2026
Merged

frankekn merged 2 commits into
mainfrom
chore/simplify-deploy-contract

Conversation

@frankekn

Copy link
Copy Markdown
Owner

Summary

  • remove stale claims that needlefish-ci automatically triggers deployment
  • document the current separation between the manual self-managed verification workflow and the legacy/source install script
  • keep CI behavior unchanged

Verification

Checked the branch against the current workflow definitions before opening this PR:

  • deploy.yml remains workflow_dispatch only
  • self-managed verification still targets ~/.local/share/needlefish-self
  • needlefish-ci still runs on PRs and pushes to main
  • pnpm check, pnpm lint, and pnpm test remain in the CI workflow
  • stale workflow_run.head_sha / deploy.yml waits on claims are absent

No runtime behavior or release files are changed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ — PASS — documentation now matches the manual verification workflow and separate source-install script.

Coverage: full diff reviewed in one pass (2 files)

Review target: PR #161 42cbdc9..fd399c0

Human callouts (non-blocking):

  • workflow: .github/workflows/ci.yml

Findings

No actionable findings. Prefer this over padding weak ones.

Checked (5)
  • Verified .github/workflows/deploy.yml:3-4 is workflow_dispatch only and .github/workflows/deploy.yml:14-41 validates an existing self-managed release without installing source.
  • Verified scripts/deploy-ubuntu.sh:6-76 separately installs source releases under ~/.local/share/needlefish.
  • Verified .github/workflows/ci.yml:6-37 has no deployment invocation.
  • TRIGGER_C cleared carrier=.github/workflows/ci.yml:3 promises=CI does not deploy and deploy is manual body=CI defines only its verification job @.github/workflows/ci.yml:18-37; deploy accepts only workflow_dispatch @.github/workflows/deploy.yml:3-4 callers=[none relies=no]
  • TRIGGER_C cleared carrier=AGENTS.md:39 and AGENTS.md:112 promises=deploy verifies an operator-installed self-managed release while deploy-ubuntu.sh performs separate source installation body=installed-release verification @.github/workflows/deploy.yml:14-41; source installation @scripts/deploy-ubuntu.sh:30-76 callers=[none relies=no]

2 calls · review 24s → critic 11s · total 34s

@github-actions github-actions Bot added the needlefish:pass Needlefish review verdict label Sep 19, 2026
@frankekn
frankekn merged commit 6b28fb8 into main Sep 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needlefish:pass Needlefish review verdict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant