docs: simplify deployment contract - #161
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
LGTM ✅ — PASS — documentation now matches the manual verification workflow and separate source-install script.
Coverage: full diff reviewed in one pass (2 files)
Review target: PR #161 42cbdc9..fd399c0
Human callouts (non-blocking):
- workflow: .github/workflows/ci.yml
Findings
No actionable findings. Prefer this over padding weak ones.
Checked (5)
- Verified
.github/workflows/deploy.yml:3-4isworkflow_dispatchonly and.github/workflows/deploy.yml:14-41validates an existing self-managed release without installing source. - Verified
scripts/deploy-ubuntu.sh:6-76separately installs source releases under~/.local/share/needlefish. - Verified
.github/workflows/ci.yml:6-37has no deployment invocation. - TRIGGER_C cleared carrier=.github/workflows/ci.yml:3 promises=CI does not deploy and deploy is manual body=CI defines only its verification job @.github/workflows/ci.yml:18-37; deploy accepts only workflow_dispatch @.github/workflows/deploy.yml:3-4 callers=[none relies=no]
- TRIGGER_C cleared carrier=AGENTS.md:39 and AGENTS.md:112 promises=deploy verifies an operator-installed self-managed release while deploy-ubuntu.sh performs separate source installation body=installed-release verification @.github/workflows/deploy.yml:14-41; source installation @scripts/deploy-ubuntu.sh:30-76 callers=[none relies=no]
2 calls · review 24s → critic 11s · total 34s
8 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needlefish-ciautomatically triggers deploymentVerification
Checked the branch against the current workflow definitions before opening this PR:
deploy.ymlremainsworkflow_dispatchonly~/.local/share/needlefish-selfneedlefish-cistill runs on PRs and pushes tomainpnpm check,pnpm lint, andpnpm testremain in the CI workflowworkflow_run.head_sha/deploy.yml waits onclaims are absentNo runtime behavior or release files are changed.