Add non-canvas element management with controller and service integration#574
Conversation
|
Looks good! There is a difference between the pen-pot tho. In the design, there can be two rows in each component. A type and a name (or ref in the case of an include). The type should be small and bold while the name would be larger. Is there is no name, the type should be the same styling as the name would've been. Also, I think elements should just be called components. 
Also, I think each component should be clickable to configure it, even if it has a button to go to the studio. That makes it easy to rename an adapter for example or to delete it. |
Improved! |
…ler integration and improved frontend according to feedback
…s non-canvas components
…implementations with ContextEditorFooter for improved consistency and clarity
stijnpotters1
force-pushed
the
feat/add-non-canvas-elements
branch
from
bfb10e5 to
fe2d1bd
Compare
|
It might be interesting to explore the possibility to give this a more flat and calm design. |
|
I changed it to a flat, calmer design: 
PS: I also fixed the hidden sidebar that could still be opened. And the color of the sidebar. Check commits for more info. |
philipsens
left a comment
philipsens
left a comment
There was a problem hiding this comment.
The border doesn't change back after dropping an element.
Also the add component modal looks very different from the one in the Studio.
…ed structure and clarity and improved sidebar layout handling
I have implemented these last tasks in the pr! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
# Conflicts: # src/main/frontend/app/routes/configurations/add-configuration-file-modal.tsx # src/main/frontend/app/routes/studio/context/node-context.tsx
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
Also take a look at the linting warnings
# Conflicts: # src/main/frontend/app/routes/studio/canvas/flow.tsx
|
3 participants
Uh oh!
There was an error while loading. Please reload this page.