Skip to content

Free the previous publication ETag before storing a new one #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Free the previous publication ETag before storing a new one #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libsofia-sip-ua/nua/nua_publish.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ static int nua_publish_client_init(nua_client_request_t *cr,
nua_handle_t *nh = cr->cr_owner;
nua_dialog_usage_t *du;
struct publish_usage *pu;
sip_etag_t *etag;

if (cr->cr_event == nua_r_publish) {
du = nua_dialog_usage_add(nh, nh->nh_ds, nua_publish_usage, NULL);
Expand All @@ -311,9 +312,14 @@ static int nua_publish_client_init(nua_client_request_t *cr,
pu = nua_dialog_usage_private(du);
pu->pu_published = 0;
if (sip->sip_if_match) {
pu->pu_etag = sip_etag_dup(nh->nh_home, sip->sip_if_match);
if (!pu->pu_etag)
/* nua_dialog_usage_add() returns the usage that is already there, so on
every refresh after the first pu_etag is set. Duplicate first and free
afterwards, so a failed allocation leaves the old tag in place. */
etag = sip_etag_dup(nh->nh_home, sip->sip_if_match);
if (!etag)
return -1;
su_free(nh->nh_home, pu->pu_etag);
pu->pu_etag = etag;
sip_header_remove(msg, sip, (sip_header_t *)sip->sip_if_match);
}
}
Expand Down