Repository navigation
Keep battery pool metric cache and resend 0 W after failed commands - #1469
Merged
Merged
Conversation
shsms
requested review from
florian-wagner-frequenz
and removed request for
a team
October 8, 2026 12:50
github-actions
Bot
added
part:docs
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Used in the following commit, which needs the same setup with different inverter bounds for each battery. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Dropping the cached data meant a battery rejoining the working set was ignored until its next sample, so the power bounds could briefly vanish and the power manager forced the target to zero. The metric fetchers already clear stale data, and the status trackers stop using batteries with stale data. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
A command that failed or timed out may still have been applied. When the last successful command was 0 W, a following 0 W command was skipped as a repeat, so the battery could keep running the failed command's power. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
force-pushed
the
pool-cache-and-zero-retry
branch
from
October 8, 2026 13:13
52b11ad to
89e3673
Compare
llucax
approved these changes
Oct 9, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The release-notes update unintentionally removes existing summary and upgrade documentation.
1 open finding
What changed in this PR
Fixes battery-pool control behavior around cached bounds and failed inverter commands.
Changes:
- Preserve cached metrics when batteries leave the working set.
- Resend 0 W after failed or timed-out inverter commands.
- Add regression tests and release notes.
| File | Description |
|---|---|
src/.../_methods.py |
Retains cached battery metrics. |
src/.../_battery_manager.py |
Clears failed inverter command state. |
tests/.../test_battery_pool.py |
Tests working-battery swaps. |
tests/.../test_battery_pool_control_methods.py |
Tests 0 W resend behavior. |
RELEASE_NOTES.md |
Documents fixes but removes unrelated release guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two battery-control bugs: the battery pool could briefly report no power bounds when batteries rejoined the working set, which made the power manager zero the target power, and a 0 W request after a failed one could be skipped as a repeat.
Changes
SendOnUpdateno longer drops cached metrics when a battery leaves the working set. A battery that comes back counts at once instead of after its next sample. Freshness is already handled by the metric fetchers' 2 s timeout and the status trackers. Pinned bytest_power_bounds_when_working_batteries_swap.BatteryManagerforgets the last set power of an inverter whose request failed or timed out, so the next request is sent even if it is 0 W. The failed request may have been applied. Pinned bytest_resend_0w_after_failure.start_streaming_power_boundsis extracted fromrun_power_bounds_testso the new test can give one battery different inverter bounds.RELEASE_NOTES.md.