Feat: shut server down if it can't find fxManager resource#61
Merged
Conversation
-> it's required for the resource to work
implemented feature
4 tasks
FjamZoo
approved these changes
Jul 12, 2026
Maximus7474
added a commit
that referenced
this pull request
Jul 12, 2026
setFxServerReady instead of detecting nucleus auth
andreutu
pushed a commit
that referenced
this pull request
Jul 13, 2026
* fix(core/process): nucleus deprecation makes validating the startup impossible -> wait for an http request from fxManager resource to say the server is ready -> with the current setup, fxManager starts last so on first tick for it server should be running * fix(core/modules/process): updated test added in #61 to use setFxServerReady instead of detecting nucleus auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even if the project can run without the fxserver resource, pretty much everything else becomes pointless, it's just a glorified web hosted console.
Tests
Additional Notes