Repository navigation
Update single-sample metagenomic binning workflow - #1453
Conversation
Test Results (powered by Planemo)Test Summary
Errored Tests
|
Test Results (powered by Planemo)Test Summary
Errored Tests
|
COMEBin runs the longest of all binners and the workflow tests stay close to the CI time limit. Turn it off in the published test cases while keeping the other binners, both refinement tools and every existing assertion unchanged. COMEBin stays enabled by default in the workflow.
|
Tests: turn COMEBin off in the published test case to keep the suite inside the CI time limit. COMEBin is the longest binning step: in the last CI runs its five assembly jobs took ~3h20m here (~4h30m for multi-sample), which brought the suite close to the six hour limit. With COMEBin disabled the test now covers SemiBin, MetaBAT2, MaxBin2 and CONCOCT plus the Binette and DAS Tool refinement paths, and all existing output assertions are unchanged. COMEBin stays enabled by default in the workflow and its behaviour is verified separately. |
Test Results (powered by Planemo)Test Summary
Failed Tests
Passed Tests
|
Test Results (powered by Planemo)Test Summary
Failed Tests
Passed Tests
|
There was a problem hiding this comment.
Similar comments would apply as in #1452:
- Removing in
annotationthe text that is already in thelabelof the step - Changing the order in the inputs
- Having sub-boxing corresponding to "coverage computation", "binning", "refinement" steps with the corresponding explanation in each box
In addition to that (that would be also valid for #1452), it would be nice to have the different steps as sections in the README with then more details in each. The README is the first thing users will see when they are looking for workflows, so we need to make the different steps stand out, especially in workflows that can be quite complex.
Replace the five boolean binner toggles with Yes/No selectors gated through map_param_value steps, reorder the inputs so reads and assemblies come first, group the workflow into annotated frames, and rewrite step annotations and the README to explain what each step does.
|
Thanks @bebatut. Applied the same improvements here: shorter explanatory annotations, assemblies and reads before the binner/Binette controls, Yes/No binner selectors, and separate coverage, binning and refinement frames. The README now introduces each analysis stage before its settings and outputs. |
bebatut
left a comment
There was a problem hiding this comment.
Thanks @paulzierep. It seems good on my side (do not have the time to review in details 😅 ), just one comment about changes in the CHANGELOG file
|
Please hold this PR until galaxyproject/galaxy#24665 is resolved. This workflow contains or embeds mapped A minimal two-step example on EU reproduced the problem: 1,001 input datasets generated 3,000 jobs before cancellation, repeatedly scheduling the same inputs. Caching is a suspected factor, not yet a confirmed cause. |
|
Addressed the inline comments in The README now explains that running DAS Tool and Binette together benefits from their different refinement approaches, requires downstream dereplication of the combined results, and can still leave contigs in multiple retained bins because dereplication does not enforce exclusive contig assignments. The embedded README is synchronized. |
bebatut
left a comment
There was a problem hiding this comment.
Thanks a lot @paulzierep. It looks good to me!
Waiting now for galaxyproject/galaxy#24665
Summary
Publish Single-sample binning 1.0 as a reusable workflow accepting paired-end
reads and corresponding assemblies from any assembler. Each sample's reads are
mapped only against its own assembly. For a pre-grouped/co-assembled input, this
means mapping the group's merged reads against its assembly.
This is the lower-cost coverage strategy: it avoids the all-samples × all-assemblies
mapping used by #1452. Prefer it for unrelated samples, large sample counts, or
limited storage/compute; use multi-coverage when cross-sample abundance patterns
are useful and resources permit.
Changes and interface
list:pairedreads and alistof assemblies, aligned by position andin the same order. Reads should already be quality-filtered and host-removed.
COMEBin. All default to on; keep at least one enabled.
standalone completeness/contamination-weight defaults remain 40 / 2.
global).mates: total bases / total reads, rounded to the nearest integer. This is a
read-count-weighted mean, not an average of per-file means.
with Markdown documentation. Yes/No binner selectors feed internal boolean gates to avoid invalid
text-to-boolean condition connections in the editor.
This standalone workflow stops at binning/refinement: grouping, assembly, dRep,
abundance estimation and final reporting belong to the parent, not this PR.
Validation
with COMEBin disabled. Fixtures are referenced by URL; collection minima are
retained rather than weakened.
gxwf validate: 36 tool states pass, zero failures/skips.audit: 457 connections checked across the three deliverables and embedded
workflows, zero invalid connections.
graph and exact test assertions. Fresh default-on EU checks and GitHub CI are
tracked separately; pending runs are not claimed as passes.
Context and related PRs
This is part of the FAIRyMAGs workflow modularization: publish reusable binning
workflows alongside an end-to-end MAG-generation parent, rather than maintaining
separate copies of the same binning logic. Each deliverable has its own branch
and PR so it can be reviewed independently.
Suggested review/merge order: Single → Multi → Parent. The parent embeds its
children, so importing it does not require importing the standalone workflows first.
Developed within FAIRyMAGs, with links
to the related workflows and learning resources in the README.
IWC checklist
FOR CONTRIBUTOR:
FOR REVIEWERS:
This workflow does/runs/performs … xyz … to generate/analyze/etc …namefield should be human readable (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless generally understood-) over underscore (_), prefer all lowercase. Folder becomes repository in iwc-workflows organization and is included in TRS id