build(deps): require circulax>=0.2.3 - #333
Merged
Merged
Conversation
jackgdsf
requested review from
MarkCunningham0410,
cdaunt,
joamatab and
thanojo
as code owners
August 12, 2026 14:31
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds circulax>=0.2.3 as a required runtime dependency and refreshes the uv.lock file to incorporate circulax and its transitive dependencies, ensuring active models like ThermalPhaseShifter are always registered and tested. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Add circulax as a runtime dependency pinned to >=0.2.3 and refresh uv.lock accordingly. The si220 cband PDK already imports circulax optionally for its active (electro-optic) models; making it a hard dependency means those models are always registered. Closes gdsfactory#321 Co-authored-by: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
jackgdsf
force-pushed
the
agent/bump-circulax-023-v2
branch
from
August 18, 2026 12:04
180d0e8 to
1cd5902
Compare
cdaunt
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321.
Adds
circulax>=0.2.3as a runtime dependency and refreshesuv.lock. The si220 cband PDK already imports circulax optionally for its active (electro-optic) models, so making it a hard dependency meansThermalPhaseShifterand friends are always registered in the PDK models dict.Branched off current
mainso the earlier attempt's CI failures don't recur — those were all stale-base artifacts (template drift deleting.github/release-drafter.yml/auto-label-pdk.ymlmid-run, andtest_models_with_wavelength_sweepmissing the non-SAX-model skip that is now on main).Validation (local, Python 3.12)
pre-commit run --all-fileswith the canonical PDK config: all 27 hooks passmake testequivalent, each file in its own pytest process as CI does:test_si220_cband.py296 passed, 3 skippedtest_si220_oband.py288 passed, 2 skippedtest_routing.py4 passedtest_si340.py268 passedtest_sin200.py268 passedtest_ge_on_si.py36 passedtest_si_sus.py42 passedtest_active_models.py5 passed (previously skipped viaimportorskip, now actually exercised)uv lockdiff is minimal: adds circulax 0.2.3 plus its transitive deps (diffrax, equinox, lineax, optimistix) and syncs the stalecspdkversion entry 1.4.4 -> 1.4.5No test files were modified.
Requested by @joamatab.
Note: this PR was prepared by an AI agent. A human must review the actual code changes before merge.
Summary by Sourcery
Make circulax a required runtime dependency and update the lockfile to support consistent active-model registration.
Enhancements:
Build: