Skip to content

build(deps): require circulax>=0.2.3 - #333

Merged
cdaunt merged 1 commit into
gdsfactory:mainfrom
jackgdsf:agent/bump-circulax-023-v2
Aug 18, 2026
Merged

build(deps): require circulax>=0.2.3#333
cdaunt merged 1 commit into
gdsfactory:mainfrom
jackgdsf:agent/bump-circulax-023-v2

Conversation

@jackgdsf

@jackgdsf jackgdsf commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Closes #321.

Adds circulax>=0.2.3 as a runtime dependency and refreshes uv.lock. The si220 cband PDK already imports circulax optionally for its active (electro-optic) models, so making it a hard dependency means ThermalPhaseShifter and friends are always registered in the PDK models dict.

Branched off current main so the earlier attempt's CI failures don't recur — those were all stale-base artifacts (template drift deleting .github/release-drafter.yml / auto-label-pdk.yml mid-run, and test_models_with_wavelength_sweep missing the non-SAX-model skip that is now on main).

Validation (local, Python 3.12)

  • pre-commit run --all-files with the canonical PDK config: all 27 hooks pass
  • make test equivalent, each file in its own pytest process as CI does:
    • test_si220_cband.py 296 passed, 3 skipped
    • test_si220_oband.py 288 passed, 2 skipped
    • test_routing.py 4 passed
    • test_si340.py 268 passed
    • test_sin200.py 268 passed
    • test_ge_on_si.py 36 passed
    • test_si_sus.py 42 passed
    • test_active_models.py 5 passed (previously skipped via importorskip, now actually exercised)
  • uv lock diff is minimal: adds circulax 0.2.3 plus its transitive deps (diffrax, equinox, lineax, optimistix) and syncs the stale cspdk version entry 1.4.4 -> 1.4.5

No test files were modified.

Requested by @joamatab.


Note: this PR was prepared by an AI agent. A human must review the actual code changes before merge.

Summary by Sourcery

Make circulax a required runtime dependency and update the lockfile to support consistent active-model registration.

Enhancements:

  • Require circulax 0.2.3 or newer at runtime so the si220 cband PDK's active models are consistently available.

Build:

  • Refresh the uv lockfile with circulax and its transitive dependencies, and synchronize the cspdk version entry.

@sourcery-ai

sourcery-ai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds circulax>=0.2.3 as a required runtime dependency and refreshes the uv.lock file to incorporate circulax and its transitive dependencies, ensuring active models like ThermalPhaseShifter are always registered and tested.

File-Level Changes

Change Details Files
Add circulax as a required runtime dependency in the project configuration.
  • Update the dependencies list to include circulax with minimum version 0.2.3
  • Ensure circulax is treated as a hard dependency rather than an optional import for active PDK models
pyproject.toml
Regenerate the uv.lock file to reflect the new circulax dependency and synchronize package versions.
  • Add lock entries for circulax 0.2.3 and its transitive dependencies (diffrax, equinox, lineax, optimistix)
  • Update the locked cspdk version from 1.4.4 to 1.4.5
  • Keep the lockfile otherwise in sync with the current dependency graph
uv.lock

Assessment against linked issues

Issue Objective Addressed Explanation
#321 Update the project to require circulax version >=0.2.3 as a dependency in the PDK.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add circulax as a runtime dependency pinned to >=0.2.3 and refresh
uv.lock accordingly. The si220 cband PDK already imports circulax
optionally for its active (electro-optic) models; making it a hard
dependency means those models are always registered.

Closes gdsfactory#321

Co-authored-by: Joaquin Matres <4514346+joamatab@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@jackgdsf
jackgdsf force-pushed the agent/bump-circulax-023-v2 branch from 180d0e8 to 1cd5902 Compare August 18, 2026 12:04
@cdaunt
cdaunt merged commit 9a729c1 into gdsfactory:main Aug 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump circulax to >=0.2.3

2 participants